feat: Added the onLongTapDown event #1587
Merged
+227
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
requested review from
spydon,
erickzanardo,
wolfenrain,
luanpotter and
renancaraujo
spydon
reviewed
Apr 28, 2022
spydon
approved these changes
Apr 28, 2022
luanpotter
reviewed
May 1, 2022
Comment on lines
+9
to
+12
| /// Instead of implementing this class directly consider using one of the | ||
| /// prebuilt mixins: | ||
| /// - [HasTappables] for a `FlameGame` | ||
| /// - [MultiTouchTapDetector] for a custom `Game` |
There was a problem hiding this comment.
maybe I am misremembering, lmk if this comment makes sense, but can't you use MultiTouchTapDetector on FlameGames if you are not using tappables and want to listen to multi-touch events?
There was a problem hiding this comment.
Since FlameGame is a Game, you can absolutely use MultiTouchTapDetector on it. The HasTappables mixing is just a more concrete implementation, which ensures the event propagates down into the component tree.
luanpotter
reviewed
May 1, 2022
Co-authored-by: Luan Nico <luanpotter27@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
onLongTapDownadded to mixins:TappableHasTappablesMultiTouchTapDetector(it existed here before, but was never invoked, so it was essentially broken)HasTappablesandMultiTouchTapDetectorare very similar in their structure, created a common interfaceMultiTapListenerthat both of them implement.GameWidgetlevel in filegestures.dart.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change